-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate vectorized ! and ~ in favor of dot syntax #20543
Conversation
I have to say there's something about unary operators that makes me feel like they should be vectorized. Of course, then we don't get loop fusion, but writing |
Having a unary operators be exempt from the "no vectorization without dot representation" ideal seems a little iffy. But at the same time, I have to agree that the dots for unary ops look weird wherever you put them, especially before the operator. ( Regarding loop fusion, it seems that they could be special-cased to achieve loop fusion, but then that's two special cases for unary ops... |
Rebased and now passing CI.
I sympathize, hence #20540 for options next dev cycle. (Will clean that up later.) Best! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Also fixes deprecation warnings due to JuliaLang/julia#20543.
With benefit of #20249, this pull request deprecates all remaining vectorized
!
and~
methods in favor of dot syntax (.!
,.~
). (.~
does not parse as a unary operator; the second commit changes that.) Best!