Deprecate negate keyword argument in Dates adjuster API #20213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkelman
added
the
kind:deprecation
omus
approved these changes
Jan 24, 2017
quinnj
approved these changes
Jan 24, 2017
|
Looks like Nanosoldier didn't get triggered? @nanosoldier |
|
Network error, had to kick the Nanosoldier: @nanosoldier |
|
yeah, #17155 hasn't had a news entry added yet |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels |
hopefully won't influence the typical path at all
tkelman
force-pushed
the
tk/negatenegate
branch
from
d236888
to
4feddef
Compare
|
I took the fact that this needed a rebase after #19920 as an opportunity to push a slight refactoring commit, which should hopefully be exactly equivalent, aside from being more concise. @nanosoldier |
|
Your benchmark job has completed - no performance regressions were detected. A full report can be found here. cc @jrevels |
Sacha0
added a commit
to Sacha0/julia
that referenced
this pull request
May 13, 2017
tkelman
pushed a commit
that referenced
this pull request
May 14, 2017
tkelman
pushed a commit
that referenced
this pull request
May 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems very unnecessary, especially now that we have unary
!for functions. Does anyone use this? We could probably remove theDateFunctionwrapper as well but that's less user-visible so shouldn't matter as much when it happens.Unfortunately keyword arguments are pretty messy to deprecate at the moment.
@nanosoldier
runbenchmarks(ALL, vs = ":master")