`@test a ≈ b atol=ε` #19901

StefanKarpinski · 2017-01-06T16:40:24Z

Potential syntax for #19899.

tkelman · 2017-01-06T18:11:08Z

base/test.jl

+
+The `@test f(args...) key=val...` form is equivalent to writing
+`@test f(args..., key=val...)` which can be useful when the expression
+does is a call using infix syntax such as approximate comparisons:


does or is, not both

stevengj · 2017-01-06T19:37:40Z

test/linalg/tridiag.jl

+# nothing.
+isdefined(:test_approx_eq_modphase) ||
+function test_approx_eq_modphase{S<:Real,T<:Real}(
+        a::StridedVecOrMat{S}, b::StridedVecOrMat{T}, err=nothing)


Rather than copy-and-paste this into two files, can you just put it in a separate file and include it?

a few packages are calling this, so better to deprecate it

stevengj · 2017-01-06T19:46:49Z

Does this work with @test a ≈ b ≈ c atol=x? We may need to define an isapprox(x,y,z...; kws) method.

TotalVerb · 2017-01-08T07:49:14Z

We don't currently call isapprox with more than two arguments. :(a ≈ b ≈ c) parses as a chained comparison.

tkelman · 2017-01-08T08:21:13Z

base/test.jl

+    @test a ≈ b atol=ε
+
+This is equivalent to the uglier test `@test ≈(a, b, atol=ε)`.
+It is an error or supply more than one expression unless the first


"an error to supply"

tkelman · 2017-01-08T08:34:01Z

base/test.jl

@@ -912,6 +953,8 @@ end
 #-----------------------------------------------------------------------
 # Legacy approximate testing functions, yet to be included

+# BEGIN TODO: deprecated in 0.6, delete in 1.0


it would be a major pain to deal with deprecations if they were all done this way. please don't encourage this, move the code to deprecated.jl with an eval into the right module

Otoh, it would avoid a ton of conflicts in base/deprecated.jl.

StefanKarpinski · 2017-01-13T19:58:45Z

In light of #19936, this becomes even more useful. Going to make some improvements and then merge this once CI passes.

tkelman · 2017-01-13T20:22:43Z

with the deprecations in the right place, please

StefanKarpinski · 2017-01-13T20:50:56Z

yeah, yeah

Makes it simple to search-and-replace calls to this macro.

Potential syntax for #19899.

Note that tolerance of the first Anscombe's quartet test in test/linalg/generic.jl had to be loosened from 10e-5 to 15e-5 because ≈ uses the norm of the difference instead of the maximum absolute difference, which is a stricter test. Closes #19899.

StefanKarpinski · 2017-01-14T01:02:55Z

AppVeyor failure is the intermittent Pkg test thing, unrelated.

StefanKarpinski · 2017-01-14T01:16:35Z

I'll leave this for review a while longer, but as far as I'm concerned, this is good to merge.

tkelman · 2017-01-14T01:17:34Z

in order to not change what module the deprecations are in, should eval them into Base.Test

StefanKarpinski · 2017-01-14T01:19:57Z

FFS. That's why I didn't move them in the first place. Evaling them into Base is so much uglier.

tkelman · 2017-01-14T01:29:08Z

less ugly than having them scattered all over the place. ugliness in deprecated.jl isn't much of a problem

StefanKarpinski · 2017-01-14T02:04:08Z

Well, I'm going to merge this and you can fix it because I'm getting on a plane in the morning and can't do anything for a good while.

tkelman · 2017-01-14T02:19:00Z

It shouldn't be on master if it's broken. Would have rather fixed it here.

6 days ago
move the code to deprecated.jl with an eval into the right module

Fixes deprecation due to JuliaLang/julia#19901.

).

…1810)

…1810) (cherry picked from commit 4c05eb2)

stevengj · 2018-02-13T00:13:02Z

Unfortunately, this doesn't work with chained comparisons:

julia> @test x ≈ y ≈ z atol=0.1
ERROR: LoadError: invalid test macro call: @test x ≈ y ≈ z atol = 0.1
Stacktrace:
 [1] error at ./error.jl:33 [inlined]
 [2] test_expr!(::String, ::Expr, ::Expr, ::Vararg{Expr,N} where N) at /Users/stevenj/Documents/Code/julia/usr/share/julia/site/v0.7/Test/src/Test.jl:278
 [3] @test(::LineNumberNode, ::Module, ::Any, ::Vararg{Any,N} where N) at /Users/stevenj/Documents/Code/julia/usr/share/julia/site/v0.7/Test/src/Test.jl:301
in expression starting at REPL[5]:1

Just ran into this in #24159.

StefanKarpinski force-pushed the sk/testkws branch from c260a04 to 535c0cd Compare January 6, 2017 16:42

kshyatt added the testsystem The unit testing framework and Test stdlib label Jan 6, 2017

tkelman reviewed Jan 6, 2017

View reviewed changes

StefanKarpinski force-pushed the sk/testkws branch 2 times, most recently from 9530ca1 to 205ed30 Compare January 6, 2017 18:15

StefanKarpinski changed the title ~~Make @test a ≈ b atol=ε mean @test ≈(a, b, atol=ε)~~ @test a ≈ b atol=ε Jan 6, 2017

StefanKarpinski force-pushed the sk/testkws branch 2 times, most recently from 739035e to 29ff301 Compare January 6, 2017 19:23

StefanKarpinski mentioned this pull request Jan 6, 2017

get rid of test_approx_eq_* #4615

Closed

stevengj reviewed Jan 6, 2017

View reviewed changes

tkelman reviewed Jan 8, 2017

View reviewed changes

tkelman suggested changes Jan 8, 2017

View reviewed changes

tkelman added the needs news A NEWS entry is required for this change label Jan 8, 2017

StefanKarpinski added 2 commits January 13, 2017 15:53

@test_approx_eq_eps: remove spaces not between arguments

cbd89ff

Makes it simple to search-and-replace calls to this macro.

Make @test a ≈ b atol=ε mean @test ≈(a, b, atol=ε)

9c58797

Potential syntax for #19899.

StefanKarpinski mentioned this pull request Jan 13, 2017

add modphase keyword for isapprox, deprecate @test_approx_eq_modphase #20021

Closed

StefanKarpinski added 2 commits January 13, 2017 17:34

Deprecate @test_approx_eq_eps (part of #4615)

c00518c

StefanKarpinski force-pushed the sk/testkws branch from eee4765 to 2ece635 Compare January 13, 2017 22:34

Move deprecated code in base/test.jl to base/deprecated.jl

83bf2db

StefanKarpinski force-pushed the sk/testkws branch from 2ece635 to 83bf2db Compare January 13, 2017 22:47

StefanKarpinski merged commit e9380c0 into master Jan 14, 2017

StefanKarpinski deleted the sk/testkws branch January 14, 2017 02:06

tkelman mentioned this pull request Jan 14, 2017

Minor cleanups, style tweaks #20031

Merged

martinholters added a commit to HSU-ANT/ACME.jl that referenced this pull request Jan 16, 2017

Use ≈ without explicit tolerance in test of diode-resistor circuit

3be464a

Fixes deprecation due to JuliaLang/julia#19901.

tkelman mentioned this pull request May 11, 2017

Make sure NEWS.md lists all 0.6 deprecations and breaking changes #21475

Closed

Sacha0 added a commit to Sacha0/julia that referenced this pull request May 11, 2017

Add NEWS.md entry for test_approx_eq[_eps] deprecations (JuliaLang#19901

69903d7

).

Sacha0 mentioned this pull request May 11, 2017

add NEWS.md entry for test_approx_eq[_eps] deprecations #21810

Merged

tkelman pushed a commit that referenced this pull request May 12, 2017

Add NEWS.md entry for test_approx_eq[_eps] deprecations (#19901). (#2…

4c05eb2

…1810)

tkelman pushed a commit that referenced this pull request May 14, 2017

Add NEWS.md entry for test_approx_eq[_eps] deprecations (#19901). (#2…

5c5f9a0

…1810) (cherry picked from commit 4c05eb2)

KristofferC removed the needs news A NEWS entry is required for this change label Nov 13, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`@test a ≈ b atol=ε` #19901

`@test a ≈ b atol=ε` #19901

StefanKarpinski commented Jan 6, 2017

tkelman Jan 6, 2017

stevengj Jan 6, 2017

tkelman Jan 8, 2017

stevengj commented Jan 6, 2017

TotalVerb commented Jan 8, 2017 •

edited

Loading

tkelman Jan 8, 2017

tkelman Jan 8, 2017

StefanKarpinski Jan 8, 2017

StefanKarpinski commented Jan 13, 2017

tkelman commented Jan 13, 2017

StefanKarpinski commented Jan 13, 2017

StefanKarpinski commented Jan 14, 2017

StefanKarpinski commented Jan 14, 2017

tkelman commented Jan 14, 2017

StefanKarpinski commented Jan 14, 2017

tkelman commented Jan 14, 2017

StefanKarpinski commented Jan 14, 2017

tkelman commented Jan 14, 2017

stevengj commented Feb 13, 2018

@test a ≈ b atol=ε #19901

@test a ≈ b atol=ε #19901

Conversation

StefanKarpinski commented Jan 6, 2017

tkelman Jan 6, 2017

Choose a reason for hiding this comment

stevengj Jan 6, 2017

Choose a reason for hiding this comment

tkelman Jan 8, 2017

Choose a reason for hiding this comment

stevengj commented Jan 6, 2017

TotalVerb commented Jan 8, 2017 • edited Loading

tkelman Jan 8, 2017

Choose a reason for hiding this comment

tkelman Jan 8, 2017

Choose a reason for hiding this comment

StefanKarpinski Jan 8, 2017

Choose a reason for hiding this comment

StefanKarpinski commented Jan 13, 2017

tkelman commented Jan 13, 2017

StefanKarpinski commented Jan 13, 2017

StefanKarpinski commented Jan 14, 2017

StefanKarpinski commented Jan 14, 2017

tkelman commented Jan 14, 2017

StefanKarpinski commented Jan 14, 2017

tkelman commented Jan 14, 2017

StefanKarpinski commented Jan 14, 2017

tkelman commented Jan 14, 2017

stevengj commented Feb 13, 2018

`@test a ≈ b atol=ε` #19901

`@test a ≈ b atol=ε` #19901

TotalVerb commented Jan 8, 2017 •

edited

Loading