Remove octal/hexadecimal parsing from IPv4. Fixes #9187 #19811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
reviewed
Jan 3, 2017
| @@ -148,6 +148,11 @@ end | |||
|
|
|||
| # Parsing | |||
|
|
|||
| const ipv4_leading_zero_error = """ | |||
| Leading zeros in IPv4 addresses are disallowed due to ambiguity. | |||
| If octal or hexadecimal, convert to decimal, otherwise remove leading zero. | |||
There was a problem hiding this comment.
IMO this reads kind of weird, since the first sentence is a complete sentence and this one isn't. Perhaps the second could be rephrased as
If the address is in octal or hexadecimal, convert it to decimal, otherwise remove the leading zero.
?
|
This is technically a breaking change, right? So I guess it would have to be noted as such in NEWS? |
|
Marking as 0.6.0 since this seems mostly ready to go. |
|
Would be gentler to have this go through a deprecation cycle, if possible. |
|
I think uses of this syntax are so incredibly rare and marginal that we can just remove support. |
|
@ararslan do you want to push a rewording here then? |
|
@tkelman The deed is done. |
|
Needs a NEWS entry in the breaking changes section. |
Sacha0
added a commit
to Sacha0/julia
that referenced
this pull request
May 11, 2017
tkelman
pushed a commit
that referenced
this pull request
May 12, 2017
tkelman
pushed a commit
that referenced
this pull request
May 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.