deprecate Dates.recur in favour of filter #19288
Conversation
|
+1 |
| @@ -1098,4 +1098,16 @@ eval(Base.LinAlg, quote | |||
| end | |||
| end) | |||
|
|
|||
| eval(Base.Dates, quote | |||
| function recur{T<:TimeType}(fun::Function, dr::StepRange{T};negate::Bool=false, limit::Int=10000) | |||
| depwarn(string("Dates.recur is deprecated, use filter instead."),:recur) | |||
There was a problem hiding this comment.
The string() part shouldn't be necessary, right?
There was a problem hiding this comment.
Good point, fixed.
simonbyrne
force-pushed
the
sb/date-recur-dep
branch
from
6cd4f1e
to
9deb07f
Compare
| @@ -1102,4 +1102,17 @@ end) | |||
| @deprecate den denominator | |||
| @deprecate num numerator | |||
|
|
|||
| # #19288 | |||
| eval(Base.Dates, quote | |||
| function recur{T<:TimeType}(fun::Function, dr::StepRange{T};negate::Bool=false, limit::Int=10000) | |||
|
The manual will need to be updated. Particularly doc/manual/dates.rst |
|
Good point. Is it worth keeping the text, or should we just get rid of it altogether? |
simonbyrne
force-pushed
the
sb/date-recur-dep
branch
from
143d216
to
c86c418
Compare
|
I think it's worth mentioning, particularly since there used to be explicit functionality for this. |
simonbyrne
force-pushed
the
sb/date-recur-dep
branch
from
c133588
to
f24ff4a
Compare
Deprecation introduced in JuliaLang#19288
Deprecation introduced in #19288
|
There was a docstring for this that genstdlib is now warning about. Should that be repurposed as a dates-specific docstring for filter? |
|
Bump @simonbyrne there's a stale docstring here giving a warning, should be cleaned up especially if we're about to transition how the docs get built. |
|
No, I don't think we need anything date-specific. I'll open a PR to fix it. |
* deprecate Dates.recur in favour of filter
Deprecation introduced in JuliaLang#19288
Should also indirectly close #17513
cc: @quinnj