Deprecate 1 argument write. fix #17612 #17654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -801,6 +801,8 @@ macro MIME(s) | |||
| end | |||
| end) | |||
|
|
|||
| @deprecate write(x) write(STDOUT::IO, x) | |||
There was a problem hiding this comment.
this should probably go at the end of the file, I don't think we're going to squeeze in any deprecations right now
|
I have updated to 0.6 deprecation. |
Sacha0
added a commit
to Sacha0/julia
that referenced
this pull request
May 14, 2017
Sacha0
added
the
kind:deprecation
tkelman
pushed a commit
that referenced
this pull request
May 16, 2017
singam-sanjay
pushed a commit
to singam-sanjay/julia
that referenced
this pull request
May 16, 2017
tkelman
pushed a commit
that referenced
this pull request
May 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Jeff points out in #17612, this is not a good shortcut for writing to
STDOUT. To make the mater even worse ifwrite("a")is executed it invokes the method injulia/base/io.jl
Line 93 in d0a378d
write(1)would write data toSTDOUT, this could be quite surprising.