Remove +-(UniformScaling, Number) to avoid ambiguous behavior as pointed out in #17083 #17607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should be deprecated first, not made an error right away |
andreasnoack
force-pushed
the
anj/uniform
branch
2 times, most recently
from
69b3a50
to
1c6be78
Compare
andreasnoack
force-pushed
the
anj/uniform
branch
from
1c6be78
to
12fdfae
Compare
mfasi
pushed a commit
to mfasi/julia
that referenced
this pull request
Sep 5, 2016
Sacha0
added
deprecation
Sacha0
added a commit
to Sacha0/julia
that referenced
this pull request
May 14, 2017
tkelman
pushed a commit
that referenced
this pull request
May 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17083. This is a small breaking change so maybe it's too late for 0.5 but I'd be surprised if anybody relies on these methods.