PowerPC64 fixes #16404
Merged
PowerPC64 fixes #16404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not seeing any TOC issues on recent LLVM versions, so remove the workaround.
Disassembling little endian PowerPC instructions is now fixed upstream with LLVM commit r242288, so we can remove this workaround.
Fast isel is causing a number of test case failures on PowerPC64. Disable it until we solve the LLVM issues.
This fixes an issue when reusing a JIT context on PowerPC64.
This fixes some little endian fast isel issues as well as setting a sane default for the generic target on little endian.
| @@ -5797,7 +5797,7 @@ extern "C" void jl_init_codegen(void) | |||
| targetFeatures); | |||
| assert(jl_TargetMachine && "Failed to select target machine -" | |||
| " Is the LLVM backend for this CPU enabled?"); | |||
| #if defined(USE_MCJIT) && !defined(_CPU_ARM_) | |||
| #if defined(USE_MCJIT) && (!defined(_CPU_ARM_) && !defined(_CPU_PPC64_)) | |||
There was a problem hiding this comment.
I'm wonder what's wrong about fastisel... it works on AArch64 but not AArch32 for example......
What's the issue you see with FastISel?
There was a problem hiding this comment.
Most likely a bug in the PowerPC64 fast-isel code, it doesn't get a whole lot of testing. We are working to find the bugs in llvm and fix them. One failure:
y = Float32(1)
i = trunc(Int32, y)We get junk, instead of 1.
There was a problem hiding this comment.
So it's a different kind of failure with ARM backend, where the codegen messes up addressing mode and causes segfault...
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of fixes for PowerPC64