improved IR #15609
Merged
improved IR #15609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you need to not add [ci skip] to the commit message so that CI can be allowed to run on this |
|
Yes, that's kind of a remnant. I'm going to add a bit more to this before merging anyway. |
JeffBezanson
force-pushed
the
jb/linear3
branch
from
e8a69d7
to
16283f5
Compare
| @@ -166,7 +166,7 @@ function show_spec_linfo(io::IO, frame::StackFrame) | |||
| else | |||
| linfo = get(frame.outer_linfo) | |||
| if isdefined(linfo, 8) | |||
There was a problem hiding this comment.
isdefined(linfo, :specTypes) ?
this avoids needing to repeatedly look up labels when interpreting or analyzing code.
wrap static parameters with (static-parameter )
LambdaInfo.ast is now LambdaInfo.code, and is just an array of statements store LambdaInfo objects in the tfunc cache, instead of just ASTs now type inference operates on InferenceState.linfo in place, and eventually copies the results to InferenceState.destination if necessary.
JeffBezanson
force-pushed
the
jb/linear3
branch
from
16283f5
to
1ee954a
Compare
|
I have no idea what this is but I am excited anyway! 🎉 |
Closed
| size_t ngensym = (jl_is_array(gensym_types) ? jl_array_len(gensym_types) : jl_unbox_long(gensym_types)); | ||
| li->slotnames = jl_alloc_cell_1d(nslots); | ||
| li->slottypes = jl_nothing; | ||
| li->slotflags = jl_alloc_array_1d(jl_array_uint8_type, nslots); |
There was a problem hiding this comment.
Missing wbs? (here and above)
|
I should summarize:
|
| li->fptr = fptr; | ||
| li->name = sname; | ||
| // TODO jb/functions: what should li->ast be? | ||
| li->ast = (jl_value_t*)jl_exprn(lambda_sym,0); jl_gc_wb(li, li->ast); | ||
| li->code = (jl_array_t*)jl_an_empty_cell; jl_gc_wb(li, li->code); |
There was a problem hiding this comment.
This wb can actually be removed but is fine to keep..
|
@yuyichao Thanks I will fix those. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#15181 rebased.