Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse(IPAddr, str): use the generic parse function for IP parsing #14676

Merged
merged 3 commits into from
Jan 15, 2016

Conversation

StefanKarpinski
Copy link
Member

Likewise parse(IPv4, str) and parse(IPv6, str).

@tkelman
Copy link
Contributor

tkelman commented Jan 14, 2016

could use a deprecation

@@ -4049,13 +4049,6 @@ itself). For matrices, returns an identity matrix of the appropriate size and ty
one

"""
parseip(addr)

Parse a string specifying an IPv4 or IPv6 ip address.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth tweaking this to be a method-specific docstring for parse?

also needs to be removed from the rst

@tkelman
Copy link
Contributor

tkelman commented Jan 14, 2016

also in contrib/BBEditTextWrangler-julia.plist

@JeffBezanson
Copy link
Member

+1

@StefanKarpinski StefanKarpinski added the needs docs Documentation for this change is required label Jan 15, 2016
StefanKarpinski added a commit that referenced this pull request Jan 15, 2016
parse(IPAddr, str): use the generic parse function for IP parsing
@StefanKarpinski StefanKarpinski merged commit a5d23b0 into master Jan 15, 2016
@kmsquire kmsquire deleted the sk/parseip branch January 15, 2016 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs docs Documentation for this change is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants