Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is quite funny: we have
but also
The reason turned out to be a bit subtle:
It seems that when no method exists, inference is returning
Any
rather thanUnion{}
for the return type?So the underlying cause is the branch for 2x2 or 3x3 matrices, the fact that the corresponding functions are defined only for
AbstractMatrix
inputs, and the fact thatgeneric_matmatmul!
can take inputs which are notAbstractMatrix
objects.Also fixes another type instability in
copy!
(it was returningUnion{Bool,typeof(B)}
which probably has no performance impact, but we might as well fix it.