Add qrfact(SparseMatrixCSC) by wrapping SPQR. #10180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasnoack
force-pushed
the
anj/spqr
branch
from
9fd3104
to
74c5b11
Compare
|
👏 |
andreasnoack
force-pushed
the
anj/spqr
branch
from
74c5b11
to
7ae8adf
Compare
|
Now including the new files and with the typos corrected. |
|
This also needs a mention in NEWS. |
andreasnoack
force-pushed
the
anj/spqr
branch
2 times, most recently
from
5a68314
to
df2eff3
Compare
… work for least squares problems. Some tests.
andreasnoack
force-pushed
the
anj/spqr
branch
2 times, most recently
from
b47bd0f
to
aab52ab
Compare
…f the functions so we have to do that by default.
andreasnoack
force-pushed
the
anj/spqr
branch
from
aab52ab
to
d8e5aab
Compare
|
The test error is not related to this pr so I'll merge. The error is because a test matrix sometimes doesn't have zero pivots even though it has most of the time. We might want to adjust the test a bit if it shows up more often. |
andreasnoack
added a commit
that referenced
this pull request
Feb 16, 2015
Add qrfact(SparseMatrixCSC) by wrapping SPQR.
|
Can we use a known constant test matrix that causes that condition? CI failures should be taken seriously and if they have known, straightforward solutions we should fix them. |
|
Yes, we can construct a matrix that fails deterministically instead, so that is the way to avoid this problem. |
|
With ab72de8 we shouldn't see the random test failures from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make
\(SparseMatrixCSC)work for least squares problems.