From 80abe17f9062ff17a727c1028284e85c2a105876 Mon Sep 17 00:00:00 2001 From: mschauer Date: Mon, 30 Jun 2014 15:59:25 +0200 Subject: [PATCH] Use chksquare in trsyl! --- base/linalg/dense.jl | 1 - base/linalg/lapack.jl | 9 ++------- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/base/linalg/dense.jl b/base/linalg/dense.jl index 3da6522702b77..135813eda5f1a 100644 --- a/base/linalg/dense.jl +++ b/base/linalg/dense.jl @@ -473,7 +473,6 @@ sylvester{T<:Integer}(A::StridedMatrix{T},B::StridedMatrix{T},C::StridedMatrix{T # AX + XA' + C = 0 function lyap{T<:BlasFloat}(A::StridedMatrix{T},C::StridedMatrix{T}) - chksquare(A, C) R, Q = schur(A) D = -Ac_mul_B(Q,C*Q) diff --git a/base/linalg/lapack.jl b/base/linalg/lapack.jl index 1eb6d99e38186..f271b1d91adb8 100644 --- a/base/linalg/lapack.jl +++ b/base/linalg/lapack.jl @@ -3672,15 +3672,10 @@ for (fn, elty, relty) in ((:dtrsyl_, :Float64, :Float64), (:ctrsyl_, :Complex64, :Float32)) @eval begin function trsyl!(transa::BlasChar, transb::BlasChar, A::StridedMatrix{$elty}, B::StridedMatrix{$elty}, C::StridedMatrix{$elty}, isgn::Int=1) - chkstride1(A) - chkstride1(B) - chkstride1(C) - m = size(A, 1) - n = size(B, 1) + chkstride1(A, B, C) + m, n = chksquare(A, B) lda = max(1, stride(A, 2)) ldb = max(1, stride(B, 2)) - if lda < m throw(DimensionMismatch("")) end - if ldb < n throw(DimensionMismatch("")) end m1, n1 = size(C) if m != m1 || n != n1 throw(DimensionMismatch("")) end ldc = max(1, stride(C, 2))