Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dimension checking for vector' * vector is broken #746

Closed
pablosanjose opened this issue Jul 15, 2020 · 0 comments · Fixed by JuliaLang/julia#36679
Closed

Dimension checking for vector' * vector is broken #746

pablosanjose opened this issue Jul 15, 2020 · 0 comments · Fixed by JuliaLang/julia#36679
Labels
bug Something isn't working regression Regression in behavior compared to a previous version

Comments

@pablosanjose
Copy link
Contributor

pablosanjose commented Jul 15, 2020

As noted by @marius311 here, the merged PR JuliaLang/julia#35257 seems to cause the following unintended behavior

julia> [1,2]' * [1,2,3.]
5.0
julia> [1,2]' * [1,2,3]
ERROR: DimensionMismatch("first array has length 2 which does not match the length of the second, 3.")

Both should error, but if the eltype is different between the two vectors, it does not. The culprit seems to be https://github.com/JuliaLang/julia/blob/eb4784a8fb7f572b12d9e4c966975bc8d4c8157f/stdlib/LinearAlgebra/src/adjtrans.jl#L247 where zip is used as a fallback

@ararslan ararslan added bug Something isn't working regression Regression in behavior compared to a previous version labels Jul 15, 2020
@KristofferC KristofferC transferred this issue from JuliaLang/julia Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression Regression in behavior compared to a previous version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants