Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Name conflicts between Base.LinAlg and Base.LinAlg.BLAS #289

Closed
denizyuret opened this issue Dec 4, 2015 · 0 comments
Closed

Name conflicts between Base.LinAlg and Base.LinAlg.BLAS #289

denizyuret opened this issue Dec 4, 2015 · 0 comments

Comments

@denizyuret
Copy link

I noticed that there are several names in common between the two:

julia> intersect(names(Base.LinAlg,true), names(Base.LinAlg.BLAS,true))
5-element Array{Symbol,1}:
 :BLAS
 :axpy!
 :dot
 :eval
 :gemv!

axpy! is explicitly imported in blas.jl but dot and gemv! are not. If this was not intentional, let's fix it by importing these two. If this was intentional, then I am not sure which dot to extend in CUBLAS for example.
@denizyuret denizyuret mentioned this issue Dec 4, 2015
Open
tkelman referenced this issue in JuliaLang/julia Dec 9, 2015
@tkelman
Merge pull request #14326 from JuliaLang/anj/import
c853712 
Fix a few naming conflicts in LinAlg/BLAS. Fixes #14268.
andreasnoack referenced this issue in JuliaLang/julia Jun 14, 2017
@andreasnoack
Revert "Fix a few naming conflicts in LinAlg/BLAS. Fixes #14268."
a61bd2e 
This reverts commit befbcec.
@andreasnoack andreasnoack mentioned this issue Jun 15, 2017
Merged
andreasnoack referenced this issue in JuliaLang/julia Jun 16, 2017
@andreasnoack
Revert "Fix a few naming conflicts in LinAlg/BLAS. Fixes #14268." (#2…
c75944f 
…2374)

* Revert "Fix a few naming conflicts in LinAlg/BLAS. Fixes #14268."

This reverts commit befbcec.

* Add test to make sure that dot(Matrix,Matrix) throws for all types
quinnj referenced this issue in JuliaLang/julia Jun 20, 2017
@andreasnoack @quinnj
Revert "Fix a few naming conflicts in LinAlg/BLAS. Fixes #14268." (#2…
add6f7f 
…2374)

* Revert "Fix a few naming conflicts in LinAlg/BLAS. Fixes #14268."

This reverts commit befbcec.

* Add test to make sure that dot(Matrix,Matrix) throws for all types
@KristofferC KristofferC transferred this issue from JuliaLang/julia Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kshyatt @denizyuret