update to use JuliaSyntax.jl v1.0.0

[inkydragon]

This pr should be merged with the PR that updates the JuliaSyntax.jl version.
The tests here are currently invalid (because JuliaSyntax.jl has not been upgraded yet)

JuliaSyntax.jl Breaking changes:

• v1.0.0 issue: Release 1.0.0 JuliaSyntax.jl#472
• PRs: https://github.com/JuliaLang/JuliaSyntax.jl/pulls?q=sort%3Aupdated-desc+is%3Apr+is%3Amerged+label%3Abreaking

[tecosaur]

Brilliant, thanks for doing this work Chengyu!

[inkydragon]

I think this pr is ready for review.
See buildkite status: https://buildkite.com/julialang/julia-master/builds/44217#0194b630-15b6-4d08-afdc-0e261d34973a

But not sure when to merge it.

One idea is to keep this pr open, and

• merge deps: update JuliaSyntax to v1.0.0 julia#57188 first
  using commit hash in my fork branch
• merge this pr
• update commit hash in julia

Otherwise this pr will not pass CI.

(Update)
We need a stable commit hash and perhaps need to merge this PR first.

[codecov]

Codecov Report

Attention: Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.

Project coverage is 66.87%. Comparing base (d6c979e) to head (2680c8b).
Report is 12 commits behind head on main.

Files with missing lines	Patch %	Lines
src/JuliaSyntaxHighlighting.jl	58.82%	7 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   66.66%   66.87%   +0.21%     
==========================================
  Files           1        1              
  Lines         156      157       +1     
==========================================
+ Hits          104      105       +1     
  Misses         52       52              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tecosaur]

Great! I'll try to review this PR in the week, seems like it should be good to just merge?

Feel free to ping me if I don't get around to this by the weekend 🙂

[tecosaur]

Sorry it's dragged on, I've just looked over these changes locally and they look good to me 👍. Thanks again for your work on this.

I'd like to fast-forward merge this, but rebasing the work into these three commits:

21edd86 Update the minimum Julia version to v1.12

67e8d6c Adapt to breaking changes with JuliaSyntax

The source changes:
1. Replace K"true" and K"false" with K"Bool"
   JuliaLang/JuliaSyntax.jl@b92fc5e5dab7
2. Rename haschildren() to is_leaf()
   JuliaLang/JuliaSyntax.jl@d8796c6ac136

Also update the tests and doctests to reflect a change in the syntax pass.

317f2c8 Use the more idiomatic JuliaSyntax API

Instead of just reaching straight into the private fields of the
relevant structs, (import and) use the methods provided by JuliaSyntax.

Specifically:
1. length(node.args)       -> numchildren(node)
2. isempty(children(node)) -> numchildren(node) == 0
3. node.args               -> children(node)
4. node.args[x]            -> node[x]
5. node.span               -> span(node)

Let me know if you're happy with this 🙂

[inkydragon]

I'm fine with those changes.
I'm not good at writing commit messages, so I always opt for each commit to contain as few changes as possible so that merging multiple commits is easy.

Feel free to push -f

[tecosaur]

I've just checked and K"Bool" causes an error on JuliaSyntax < 1.0, so I'm also going to need to bump the compat when backporting this (note to self).

[tecosaur]

Thanks for the help!