Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FiniteDiff: eagerly promote Bool type to float #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johnnychen94
Copy link
Member

tests are needed

fixes #32

@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #33 (bda38d0) into master (18d2856) will decrease coverage by 0.40%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
- Coverage   92.07%   91.66%   -0.41%     
==========================================
  Files           5        5              
  Lines         227      228       +1     
==========================================
  Hits          209      209              
- Misses         18       19       +1     
Impacted Files Coverage Δ
src/diff.jl 94.91% <0.00%> (-1.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18d2856...bda38d0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FiniteDiff: support Bool array
1 participant