miscellaneous fixes and improvements #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's often convenient to construct a `Header` object that is the same as another `Header` object except with some fields modified. This lets that be expressed by using keywords to pass the modified fields.
Codecov Report
@@ Coverage Diff @@
## master #104 +/- ##
==========================================
- Coverage 96.37% 96.26% -0.11%
==========================================
Files 4 4
Lines 634 643 +9
==========================================
+ Hits 611 619 +8
- Misses 23 24 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing the
Tar.listcallback to receive the raw header data (especially in the form of a vector of fields) is highly useful for analyzing wild tarballs. I implemented this when working on adding support for hard links so that I could look at a tarball containing hard links more easily.Adding a
Headermethod that takes an existingHeaderobject and modifies some of its fields is a pattern that's used in various places in the code base which this method makes cleaner and clearer.This makes all cases where the end of a tarball is encountered before it is expected throw the same
EOFErrorwhereas previously some places threw that error while others threw a generic error with a premature end of file message.This changes also makes the definition of a
skipmethod for processes conditional so that when testing with a Julia version that hasTaras a stdlib (and thus already has this method defined), we don't break precompilation by redefining that method.