Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add the unsupported_file_type::Symbol kwarg to the Tar.create_tarball function #137

Closed
wants to merge 1 commit into from

Conversation

DilumAluthge
Copy link
Member

@DilumAluthge DilumAluthge commented Mar 25, 2022

This pull request adds the unsupported_file_type::Symbol kwarg to the Tar.create_tarball function.

The possible values of unsupported_file_type are:

  1. :error (default)
  2. :warn

@DilumAluthge
Copy link
Member Author

FYI, the motivation for the Options struct is that I was thinking we might add other similar options in the future, and it'll get real annoying to have to pass a lot of keyword arguments around everywhere, so I thought it would be easier to just pass around a single Options.

@StefanKarpinski
Copy link
Member

The Options thing makes sense but should then probably include at least set_permissions and maybe some of the others.

@DilumAluthge
Copy link
Member Author

Looks like this has gone pretty stale at this point.

@DilumAluthge DilumAluthge deleted the dpa/unsupported-files-werror branch April 25, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants