don't directly depend on ColorTypes and FixedPointNumbers #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
=======================================
Coverage 73.61% 73.61%
=======================================
Files 1 1
Lines 288 288
=======================================
Hits 212 212
Misses 76 76
Continue to review full report at Codecov.
|
|
Thanks, this is a much better solution |
timholy
added a commit
to JuliaIO/ImageMagick.jl
that referenced
this pull request
Sep 9, 2020
xref JuliaRegistries/General#11114 By switching to depending on just ImageCore we make the dependencies easier to maintain (e.g., JuliaIO/QuartzImageIO.jl#66).
timholy
added a commit
to JuliaIO/ImageMagick.jl
that referenced
this pull request
Sep 9, 2020
xref JuliaRegistries/General#11114 By switching to depending on just ImageCore we make the dependencies easier to maintain (e.g., JuliaIO/QuartzImageIO.jl#66).
timholy
added a commit
to JuliaIO/ImageMagick.jl
that referenced
this pull request
Sep 10, 2020
xref JuliaRegistries/General#11114 By switching to depending on just ImageCore we make the dependencies easier to maintain (e.g., JuliaIO/QuartzImageIO.jl#66).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just hit this in #65
Given that this package already depends on ImageCore, it doesn't need to directly maintain
ColorTypesandFixedPointNumberversions.I also added a CompatHelper for this.
closes #61
closes #64