From caf97ae97470aafd4edd3b8cdc97a88c1139ece4 Mon Sep 17 00:00:00 2001 From: Justin Willmert Date: Tue, 1 Sep 2020 09:35:18 -0500 Subject: [PATCH] Add deprecated bindings for backwards compatibility with ecosystem packages Namely, get the tests of JLD.jl and MAT.jl to pass again. --- src/HDF5.jl | 2 ++ src/deprecated.jl | 12 ++++++++++++ 2 files changed, 14 insertions(+) create mode 100644 src/deprecated.jl diff --git a/src/HDF5.jl b/src/HDF5.jl index c00b2460a..7b16a4e4c 100644 --- a/src/HDF5.jl +++ b/src/HDF5.jl @@ -2641,4 +2641,6 @@ function __init__() return nothing end +include("deprecated.jl") + end # module diff --git a/src/deprecated.jl b/src/deprecated.jl new file mode 100644 index 000000000..31cfa3b3d --- /dev/null +++ b/src/deprecated.jl @@ -0,0 +1,12 @@ +import Base: @deprecate, depwarn + +### Changed in PR#629 +# - HDF5Dataset.xfer from ::Hid to ::HDF5Properties +@deprecate h5d_read(dataset_id::Hid, memtype_id::Hid, buf::AbstractArray, xfer::HDF5Properties) h5d_read(dataset_id, memtype_id, buf, xfer.id) +@deprecate h5d_write(dataset_id::Hid, memtype_id::Hid, buf::AbstractArray, xfer::HDF5Properties) h5d_write(dataset_id, memtype_id, buf, xfer.id) +@deprecate h5d_write(dataset_id::Hid, memtype_id::Hid, str::String, xfer::HDF5Properties) h5d_write(dataset_id, memtype_id, str, xfer.id) +@deprecate h5d_write(dataset_id::Hid, memtype_id::Hid, x::T, xfer::HDF5Properties) where {T<:Union{HDF5Scalar, Complex{<:HDF5Scalar}}} h5d_write(dataset_id, memtype_id, x, xfer.id) +@deprecate h5d_write(dataset_id::Hid, memtype_id::Hid, strs::Array{S}, xfer::HDF5Properties) where {S<:String} h5d_write(dataset_id, memtype_id, strs, xfer.id) +@deprecate h5d_write(dataset_id::Hid, memtype_id::Hid, v::HDF5Vlen{T}, xfer::HDF5Properties) where {T<:Union{HDF5Scalar,CharType}} h5d_write(dataset_id, memtype_id, v, xfer.id) +# - p_create lost toclose argument +@deprecate p_create(class, toclose::Bool, pv...) p_create(class, pv...)