Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows test failures for SZIP compression #1106

Closed
simonbyrne opened this issue Sep 5, 2023 · 2 comments
Closed

Windows test failures for SZIP compression #1106

simonbyrne opened this issue Sep 5, 2023 · 2 comments

Comments

@simonbyrne
Copy link
Collaborator

filter: Test Failed at D:\a\HDF5.jl\HDF5.jl\test\filter.jl:248
  Expression: HDF5.API.h5z_filter_avail(HDF5.API.H5Z_FILTER_SZIP)

Stacktrace:
 [1] macro expansion
   @ C:\hostedtoolcache\windows\julia\1.9.3\x64\share\julia\stdlib\v1.9\Test\src\Test.jl:478 [inlined]
 [2] macro expansion
   @ D:\a\HDF5.jl\HDF5.jl\test\filter.jl:248 [inlined]
 [3] macro expansion
   @ C:\hostedtoolcache\windows\julia\1.9.3\x64\share\julia\stdlib\v1.9\Test\src\Test.jl:1498 [inlined]
 [4] top-level scope
   @ D:\a\HDF5.jl\HDF5.jl\test\filter.jl:15

MSYS2 uses cmake to build HDF5.

https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-hdf5/PKGBUILD

HDF Group changed cmake to deprecate SZIP in favor of libaec.

However, HDF Group does this weird thing where they use their own cmake build for libaec, which is different than the way everyone else builds libaec.

https://github.com/HDFGroup/hdf5/blob/develop/config/cmake/LIBAEC/CMakeLists.txt

I'm trying to figure out how to point HDF5 to the libsz that Yggdrasil builds.

Originally posted by @mkitti in #1105 (comment)

@mkitti
Copy link
Member

mkitti commented Sep 6, 2023

I solved this in conda-forge a few weeks ago by upgrading to HDF5 1.14.2.
conda-forge/hdf5-feedstock#207

The big difference there is that they use autoconf to build HDF5 rather than cmake:
https://github.com/conda-forge/hdf5-feedstock/blob/main/recipe/build.sh

@mkitti mkitti changed the title Windows test failures Windows test failures for SZIP compression Sep 6, 2023
@mkitti
Copy link
Member

mkitti commented Sep 6, 2023

Potential fix: msys2/MINGW-packages#18328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants