Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve between binary and ASCII formats #14

Closed
sjkelly opened this issue May 30, 2015 · 2 comments
Closed

Resolve between binary and ASCII formats #14

sjkelly opened this issue May 30, 2015 · 2 comments

Comments

@sjkelly
Copy link
Member

sjkelly commented May 30, 2015

In Meshes there are often binary and ASCII formats for each file type. There doesn't seem to be a way to resolve which one you would like easily. For example file"foo.ply creates a File{:ply}("foo.ply"), but the only dispatchable signatures are File{:binary_ply}, so I cannot use the m_str form.

What should be the behavior here?

@SimonDanisch
Copy link
Member

I wrote a prototype to solve this and opened an issue to get some feedback in #13

@timholy
Copy link
Member

timholy commented Aug 9, 2015

Closed by #15, see

add_format(format"PBMText", b"P1", ".pbm")
add_format(format"PGMText", b"P2", ".pgm")
add_format(format"PPMText", b"P3", ".ppm")
add_format(format"PBMBinary", b"P4", ".pbm")
add_format(format"PGMBinary", b"P5", ".pgm")
add_format(format"PPMBinary", b"P6", ".ppm")

@timholy timholy closed this as completed Aug 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants