Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JLD2 compat #84

Closed
wants to merge 3 commits into from
Closed

Update JLD2 compat #84

wants to merge 3 commits into from

Conversation

ReubenJ
Copy link
Contributor

@ReubenJ ReubenJ commented Oct 21, 2024 •
edited
Loading

Fixes #83

  • Updates the JLD2 compat entry
    • Bump MetaGraphsNext patch version number
  • Removes the unnecessary docs/Manifest.toml
  • Remove outdated strict argument to makedocs(...)

@ReubenJ ReubenJ mentioned this pull request Oct 21, 2024
Merged
@gdalle
Copy link
Member

gdalle commented Oct 21, 2024

Sorry I also had to do those for #85 to pass CI, in retrospect I should have merged them in the other order. Can you merge master into this PR?

@ReubenJ ReubenJ closed this Oct 21, 2024
@ReubenJ ReubenJ deleted the chore/update-JLD2-compat branch October 21, 2024 17:50
@gdalle
Copy link
Member

gdalle commented Oct 21, 2024

Or we can merge it into the other one

@ReubenJ
Copy link
Contributor Author

ReubenJ commented Oct 21, 2024

Oops... just got thoroughly confused switching between the branches and deleted the wrong one. I guess it's all sorted now?

@gdalle
Copy link
Member

gdalle commented Oct 21, 2024

yup, all good! thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ReubenJ @gdalle