Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JLD2 compat #83

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Update JLD2 compat #83

merged 1 commit into from
Oct 21, 2024

Conversation

filchristou
Copy link
Contributor

No description provided.

@gdalle
Copy link
Member

gdalle commented Oct 14, 2024

Any idea why docs fail?

@ReubenJ
Copy link
Contributor

ReubenJ commented Oct 21, 2024

There shouldn't be a docs/Manifest.toml, AFAIK. See Graphs.jl: https://github.com/JuliaGraphs/Graphs.jl/tree/master/docs. Removing the file (+ adding to .gitignore) should fix the issue.

It looks like the current manifest is out of sync with the docs Project.toml or something, causing the action to fail.

@ReubenJ
Copy link
Contributor

ReubenJ commented Oct 21, 2024

Working in my own fork: ReubenJ#1

I can open a new PR or push the changes to your fork @filchristou.

@gdalle
Copy link
Member

gdalle commented Oct 21, 2024

Either one would be great, thanks!

@ReubenJ ReubenJ mentioned this pull request Oct 21, 2024
Closed
@ReubenJ
Copy link
Contributor

ReubenJ commented Oct 21, 2024

Sounds good. Just opened #84 👍

@gdalle gdalle merged commit 495c260 into JuliaGraphs:master Oct 21, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filchristou @gdalle @ReubenJ