Add support for predicates in TriRefinement
#1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1070 +/- ##
==========================================
+ Coverage 87.52% 87.54% +0.01%
==========================================
Files 188 188
Lines 5922 5931 +9
==========================================
+ Hits 5183 5192 +9
Misses 739 739 ☔ View full report in Codecov by Sentry. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
juliohm
reviewed
Sep 18, 2024
juliohm
reviewed
Sep 18, 2024
juliohm
reviewed
Sep 18, 2024
Co-authored-by: Júlio Hoffimann <[email protected]>
juliohm
approved these changes
Sep 19, 2024
eliascarv
changed the title
TriRefinementTriRefinement
eliascarv
added a commit
that referenced
this pull request
Sep 19, 2024
* Add support por predicates in 'TriRefinement' * Apply suggestions * Apply suggestions * Apply suggestions * Apply suggestions * Rename variables * Fix typo * Rename variables * Update src/refinement/tri.jl Co-authored-by: Júlio Hoffimann <[email protected]> * Add tests * Add more tests * Update code order * Update code order --------- Co-authored-by: Júlio Hoffimann <[email protected]>
eliascarv
added a commit
that referenced
this pull request
Sep 19, 2024
* Add support for predicates in 'TriRefinement' * Apply suggestions * Apply suggestions * Apply suggestions * Apply suggestions * Rename variables * Fix typo * Rename variables * Update src/refinement/tri.jl Co-authored-by: Júlio Hoffimann <[email protected]> * Add tests * Add more tests * Update code order * Update code order --------- Co-authored-by: Júlio Hoffimann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.