Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Inlay Hints in VSCode for all open files #536

Open
Zentrik opened this issue Jan 17, 2024 · 0 comments
Open

Show Inlay Hints in VSCode for all open files #536

Zentrik opened this issue Jan 17, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@Zentrik
Copy link
Collaborator

Zentrik commented Jan 17, 2024

Currently the VSCode Inlay hints only show up for the file in which the method we are descending on is defined.
It would be nice to show hints for all open files, this would require a function being added to the VSCode extension to expose the open files.
Alternatively, we could hack around it by showing hints for all files in a package.
I'm hesitant to show hints in all files as that would probably slow things down a lot.

Relevant line in source code

Cthulhu.jl/src/codeview.jl

Lines 360 to 361 in 575a732

# Check if callsite is not just filling in default arguments and defined in same file as source_mi
if mi == source_mi || mi.def.file != source_mi.def.file

@Zentrik Zentrik added the enhancement New feature or request label Jan 17, 2024
@Zentrik Zentrik changed the title Annotate source code in VSCode for all open files Show Inlay Hints in VSCode for all open files Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant