Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider dropping SQLite.jl APIs entirely in favor of DBInterface.jl #284

Open
jeremiahpslewis opened this issue Feb 1, 2022 · 3 comments

Comments

@jeremiahpslewis
Copy link
Contributor

It seems like there are a number of errors / user challenges which arise as a result of the overlapping / intersecting API domains. It might make sense (as part of a breaking change release) to drop the 'custom' SQLite interface as much as possible in favor of the generic DBInterface onee.

@quinnj
Copy link
Member

quinnj commented Feb 2, 2022

Yeah; I'm in favor. Up for making a PR @jeremiahpslewis ?

@jeremiahpslewis
Copy link
Contributor Author

Happy to do this if I get a chance, I'd break it up into 2 PRs:

  1. Remove all overlapping SQLite -DBInterface tests
  2. Remove / deprecate all overlapping code

@quinnj
Copy link
Member

quinnj commented Feb 11, 2022

That sounds like a great plan @jeremiahpslewis!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants