[WIP] Get tests passing on Julia v0.4-v0.6 #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By the way, I've thought about the discussion in #48 (comment) which I believe this will also suffer from (one of the reasons for the WIP tag) but the referenced functionality does not seem to be tested anywhere, so making sure an implementation is working would be tricky. Is there a test case? |
|
A good test case: make a string type that doesn't rely on an array of bytes and call |
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
===========================================
- Coverage 75.56% 11.62% -63.94%
===========================================
Files 3 3
Lines 221 215 -6
===========================================
- Hits 167 25 -142
- Misses 54 190 +136
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will require JuliaDatabases/DBInterface.jl#16 to be merged to get tests passing on v0.6. Probably worth registering DBI and tagging a version. Intended to eventually fix #52 and will close #51