Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why isn't Base.close used? #24

Closed
davidanthoff opened this issue Feb 14, 2020 · 1 comment
Closed

Why isn't Base.close used? #24

davidanthoff opened this issue Feb 14, 2020 · 1 comment

Comments

@davidanthoff
Copy link

That seems exactly the right function?

@quinnj
Copy link
Member

quinnj commented Feb 26, 2020

It's safer to make our own interface function here; Base.close has certain semantics and meaning and we may not want to follow or guarantee the same things. We discovered this in Tables.jl w/ relying on getproperty and propertynames; there might be certain types/scenarios where Base.close is already defined and already has a defined behavior and it's awkward to overload now for DBInterface.

Requiring our own DBInterface.close! lets us avoid any weirdness in all of that.

@quinnj quinnj closed this as completed Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants