Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify what can/should be close! ed #23

Closed
davidanthoff opened this issue Feb 14, 2020 · 1 comment
Closed

Clarify what can/should be close! ed #23

davidanthoff opened this issue Feb 14, 2020 · 1 comment

Comments

@davidanthoff
Copy link

Right now the README looks like one can close statements, but presumably one can also close results and connections?

Maybe it would be good if the convention for users of the API is that they actually should call close! on connections, statements and results?

@quinnj
Copy link
Member

quinnj commented Mar 3, 2021

Ok, we've recently updated the docs on close! and I just fixed the docs generation, which can be seen here: https://juliadatabases.org/DBInterface.jl/dev/

@quinnj quinnj closed this as completed Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants