Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing inference for skipmissings #117

Closed
pdeffebach opened this issue Jul 18, 2020 · 2 comments
Closed

Fixing inference for skipmissings #117

pdeffebach opened this issue Jul 18, 2020 · 2 comments

Comments

@pdeffebach
Copy link
Contributor

I remembered this PR in base Julia fixing the type inference in sum(skipmissing(x)).

I tried to do the simple change in that PR and it didn't work. Will this only work in 1.5?
@nalimilan
Copy link
Member

Not sure. Can you retry now that 1.5 has been released?

@pdeffebach
Copy link
Contributor Author

It works now. There were already tests for it, I guess. I'm a bit confused, though because I was checking on 1.4 and those @inferred tests should be running. nonetheless the fix is in #118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nalimilan @pdeffebach