-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove @with, add @attach #367
Conversation
CI errors I do not see where you deprecate |
Co-authored-by: Bogumił Kamiński <[email protected]>
Co-authored-by: Bogumił Kamiński <[email protected]>
Tests pass |
There are some doctest failures |
This can be a small version bump, right? Since it just deprecates, we don't need to make a |
we add new |
Okay I'm just going to merge this with a minor version bump. I don't want to release too many breaking changes and I want people to see the deprecation. I will also announce on discourse soon. |
OK |
Sorry, for some reason I missed this. It's really unfortunate that Julia exports this general name now. Have you considered calling it |
|
Closing this due to JuliaLang/julia#53004 (comment) being merged |
fixes #364