Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @with, add @attach #367

Closed
wants to merge 13 commits into from
Closed

Remove @with, add @attach #367

wants to merge 13 commits into from

Conversation

pdeffebach
Copy link
Collaborator

fixes #364

@bkamins
Copy link
Member

bkamins commented Nov 1, 2023

CI errors

I do not see where you deprecate @with (I think we should keep it at least for a while). @nalimilan - what do you think?

src/macros.jl Outdated Show resolved Hide resolved
src/macros.jl Outdated Show resolved Hide resolved
@pdeffebach
Copy link
Collaborator Author

Tests pass

@bkamins
Copy link
Member

bkamins commented Nov 2, 2023

There are some doctest failures

@pdeffebach
Copy link
Collaborator Author

This can be a small version bump, right? Since it just deprecates, we don't need to make a 0.15.0 version.

@bkamins
Copy link
Member

bkamins commented Nov 7, 2023

we add new @attach. In the past, we would e.g. in DataFrames.jl make 0.15 release. But recently people were saying that such minor changes are OK to be made in 0.14.2.

@pdeffebach
Copy link
Collaborator Author

Okay I'm just going to merge this with a minor version bump. I don't want to release too many breaking changes and I want people to see the deprecation.

I will also announce on discourse soon.

@bkamins
Copy link
Member

bkamins commented Dec 14, 2023

OK

@nalimilan
Copy link
Member

Sorry, for some reason I missed this. It's really unfortunate that Julia exports this general name now. Have you considered calling it @within instead of @attach (which indeed has a bad reputation in R as it attaches copies of columns to the global environment)?

@pdeffebach
Copy link
Collaborator Author

@within is a good name. I guess I still prefer @attach since

  1. It's a verb, kind of like @select, @transform etc.
  2. I like the idea of us re-doing an R feature, but "correctly", without the scoping and performance drawbacks of attach.

@pdeffebach
Copy link
Collaborator Author

Closing this due to JuliaLang/julia#53004 (comment) being merged

@pdeffebach pdeffebach closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@with macro clashes with Base.@with in Julia 1.11+
3 participants