Deprecate keys(df), values(df)

Of the associative methods left from the days when when
DataFrame <: Associative, these two are pure duplication of functionality.

Author: garborg

src/abstractdataframe/abstractdataframe.jl

@@ -130,8 +130,6 @@ end
 
 Base.haskey(df::AbstractDataFrame, key::Any) = haskey(index(df), key)
 Base.get(df::AbstractDataFrame, key::Any, default::Any) = haskey(df, key) ? df[key] : default
-Base.keys(df::AbstractDataFrame) = keys(index(df))
-Base.values(df::AbstractDataFrame) = columns(df)
 Base.isempty(df::AbstractDataFrame) = ncol(df) == 0
 
 ##############################################################################

src/deprecated.jl

@@ -25,6 +25,9 @@ Base.@deprecate by(d::AbstractDataFrame, cols, s::Vector{Symbol}) aggregate(d, c
 Base.@deprecate by(d::AbstractDataFrame, cols, s::Symbol) aggregate(d, cols, eval(s))
 Base.@deprecate nullable!(colnames::Array{Symbol,1}, df::AbstractDataFrame) nullable!(df, colnames)
 Base.@deprecate nullable!(colnums::Array{Int,1}, df::AbstractDataFrame) nullable!(df, colnums)
+import Base: keys, values
+Base.@deprecate keys(df::AbstractDataFrame) names(df)
+Base.@deprecate values(df::AbstractDataFrame) DataFrames.columns(df)
 
 const DEFAULT_COLUMN_ELTYPE = Float64
 function DataFrame(nrows::Integer, ncols::Integer)

test/dataframe.jl

@@ -83,8 +83,6 @@ module TestDataFrame
     @test !haskey(df, :c)
     @test get(df, :a, -1) === df.columns[1]
     @test get(df, :c, -1) == -1
-    @test keys(df) == [:a, :b]
-    @test values(df) == Any[df[:a], df[:b]]
     @test !isempty(df)
 
     @test empty!(df) === df