Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes incorrect header size when reading and writing. #31

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

divbyzerofordummies
Copy link
Contributor

Writing: Delimiter 0xD was probably ignored in the header size.
Reading: Some files have a 0xD before the end of the header length is reached.

Fixes #30

Writing: Delimiter 0xD was probably ignored in the header size.
Reading: Some files have a 0xD before the end of the header length is reached.
Copy link
Collaborator

@visr visr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me, thanks for the thorough explanation.

@visr visr merged commit 7a3c7c0 into JuliaData:main Oct 15, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Header length is not considered when loading DBF; and possibly incorrect when saving it
3 participants