Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn("foo") -> @warn("foo") etc #63

Closed
oxinabox opened this issue Jun 29, 2018 · 1 comment
Closed

warn("foo") -> @warn("foo") etc #63

oxinabox opened this issue Jun 29, 2018 · 1 comment

Comments

@oxinabox
Copy link

It would be good to catch the low-hanging fruit on fixing for the logging changes.
Just getting the single argument forms of info, and warn
would presumably catch 90% of all uses.

Slack-dump for context:

Lyndon White [6:35 PM]
Does Femto cleaner not do warn(foo) --> @warn(foo) ?

Fredrik Ekre [6:36 PM]
No

Lyndon White [6:36 PM]
Should I open an issue on Deprecations.jl?

Fredrik Ekre [6:37 PM]
I am not sure the transformation is always possible though

Lyndon White [6:38 PM]
You are probably right, (though idk why) that issue is listed as a breaking change so the deprecation mustn't always work

Fredrik Ekre [6:39 PM]
warn takes several arguments for example

Lyndon White [6:39 PM]
It might still be better to have Femtocleaner fix it, since presumably 90% of the time it does work?
Maybe making it fix it in the simplest case

Fredrik Ekre [6:39 PM]
Yea
warn("foo") -> @warn("foo") for example

@KristofferC
Copy link
Contributor

This is also included in the list at #20

@Keno Keno closed this as completed in a3764fe Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants