Remove trailing slash in "Official https://julialang.org/ release" (#348

) * Remove trailing slash in "Official https://julialang.org/ release" * check VERSION and use an if statement * Better comment * Support julia versions above 1.99 * Fixup * use BRE syntax * Add bug in v1.9 in exchange for readability Co-authored-by: Elliot Saba <[email protected]> * Fix undef val error and adjust comment * Revert a26c807 It made CI fail in a new way. * Update utilities/build_julia.sh --------- Co-authored-by: Elliot Saba <[email protected]> Co-authored-by: Dilum Aluthge <[email protected]>
JuliaCI · Aug 24, 2024 · 4571a54 · 4571a54
1 parent 63ad800
commit 4571a54
Showing 1 changed file with 13 additions and 1 deletion.
diff --git a/utilities/build_julia.sh b/utilities/build_julia.sh
@@ -38,7 +38,19 @@ MFLAGS+=( "-j${JULIA_CPU_THREADS}")
 
 # Add a few default flags to our make flags:
 MFLAGS+=( "VERBOSE=1" )
-MFLAGS+=( "TAGGED_RELEASE_BANNER=Official https://julialang.org/ release" )
+# Taken from https://stackoverflow.com/a/4024263
+verlte() {
+    printf '%s\n' "$1" "$2" | sort -C -V
+}
+verlt() {
+    ! verlte "$2" "$1"
+}
+if verlt "1.12" "$(cat VERSION)"; then
+    MFLAGS+=( "TAGGED_RELEASE_BANNER=Official https://julialang.org release" )
+else
+    # Keep trailing slash for compatability. The slash was removed in 1.12 with https://github.com/JuliaLang/julia/pull/53978
+    MFLAGS+=( "TAGGED_RELEASE_BANNER=Official https://julialang.org/ release" )
+fi
 MFLAGS+=( "JULIA_CPU_TARGET=${JULIA_CPU_TARGET}" )
 
 # Finish off with any extra make flags from the `.arches` file