Skip to content

Commit 4571a54

Browse files
LilithHafnerstaticfloatDilumAluthge
authored
Remove trailing slash in "Official https://julialang.org/ release" (#348)
* Remove trailing slash in "Official https://julialang.org/ release" * check VERSION and use an if statement * Better comment * Support julia versions above 1.99 * Fixup * use BRE syntax * Add bug in v1.9 in exchange for readability Co-authored-by: Elliot Saba <[email protected]> * Fix undef val error and adjust comment * Revert a26c807 It made CI fail in a new way. * Update utilities/build_julia.sh --------- Co-authored-by: Elliot Saba <[email protected]> Co-authored-by: Dilum Aluthge <[email protected]>
1 parent 63ad800 commit 4571a54

File tree

1 file changed

+13
-1
lines changed

1 file changed

+13
-1
lines changed

utilities/build_julia.sh

+13-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,19 @@ MFLAGS+=( "-j${JULIA_CPU_THREADS}")
3838

3939
# Add a few default flags to our make flags:
4040
MFLAGS+=( "VERBOSE=1" )
41-
MFLAGS+=( "TAGGED_RELEASE_BANNER=Official https://julialang.org/ release" )
41+
# Taken from https://stackoverflow.com/a/4024263
42+
verlte() {
43+
printf '%s\n' "$1" "$2" | sort -C -V
44+
}
45+
verlt() {
46+
! verlte "$2" "$1"
47+
}
48+
if verlt "1.12" "$(cat VERSION)"; then
49+
MFLAGS+=( "TAGGED_RELEASE_BANNER=Official https://julialang.org release" )
50+
else
51+
# Keep trailing slash for compatability. The slash was removed in 1.12 with https://github.com/JuliaLang/julia/pull/53978
52+
MFLAGS+=( "TAGGED_RELEASE_BANNER=Official https://julialang.org/ release" )
53+
fi
4254
MFLAGS+=( "JULIA_CPU_TARGET=${JULIA_CPU_TARGET}" )
4355

4456
# Finish off with any extra make flags from the `.arches` file

0 commit comments

Comments
 (0)