Use bigger vector for Union benchmarks #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should limit spurious results for sum. It also reflects better typical use cases (data frame columns with missing values in large datasets).
ararslan
approved these changes
Jul 5, 2018
|
@nalimilan I'll retune the benchmarks now. If you don't hear from me in a few hours, please ping me with a reminder to finish up. 🙂 |
|
There's no hurry, I just wanted to do that before I forget. |
|
It's ready now so you can run Nanosoldier again wherever and the change will be reflected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should limit spurious results for sum. It also reflects better typical use cases (data frame columns with missing values in large datasets).