Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need to call it Star? #19

Closed
elehcim opened this issue Oct 27, 2021 · 2 comments
Closed

Do we need to call it Star? #19

elehcim opened this issue Oct 27, 2021 · 2 comments

Comments

@elehcim
Copy link
Contributor

elehcim commented Oct 27, 2021

I'm referring to

struct Star{P, V, A, M, E, F, Et, D, dP, dE, Prs, T_1, I<:Integer} <: AbstractParticle3D

Would be something like Particle more appropriate?

@islent
Copy link
Member

islent commented Oct 28, 2021

Data fields in Star are merely designed for Gadget-like gravitational force solver. If one is implementing a simple force solver, he might choose Ball::AbstractParticle3D:

struct Ball{P, V, A, M, I<:Integer} <: AbstractParticle3D
    Pos::PVector{P}
    Vel::PVector{V}
    Acc::PVector{A}
    Mass::M
    ID::I
end

GadgetParticle may be more appropriate :D

@elehcim
Copy link
Contributor Author

elehcim commented Oct 28, 2021

GadgetParticle may be more appropriate :D
I agree :)

Ball::AbstractParticle3D is a good suggestion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants