Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in dsphdr #23

Open
cekmsu opened this issue Mar 31, 2024 · 2 comments · May be fixed by #29
Open

Bug in dsphdr #23

cekmsu opened this issue Mar 31, 2024 · 2 comments · May be fixed by #29

Comments

@cekmsu
Copy link

cekmsu commented Mar 31, 2024

SPICE.jl/src/d.jl

Line 2025 in 62323bd

jacobi

Must be:

    handleerror()
    permutedims(jacobi)
@cekmsu
Copy link
Author

cekmsu commented Jul 13, 2024

SPICE.jl/test/d.jl

Lines 664 to 670 in 9f6f1f9

@testset "dsphdr" begin
output = dsphdr(-1.0, 0.0, 0.0)
expected = [-1.0 0.0 0.0;
0.0 0.0 -1.0;
0.0 -1.0 0.0]
@test output ≈ expected
end

It is a weak test. It does not catch this bug.

@helgee
Copy link
Member

helgee commented Jul 13, 2024

PRs are welcome 👍

@cekmsu cekmsu linked a pull request Jul 13, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bug in dsphdr cekmsu/SPICE.jl
2 participants
@helgee @cekmsu