Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "Example ran successful" from examples #68

Closed
singla-shivam opened this issue Jul 3, 2022 · 0 comments · Fixed by #69
Closed

Remove "Example ran successful" from examples #68

singla-shivam opened this issue Jul 3, 2022 · 0 comments · Fixed by #69
Assignees
@singla-shivam
Labels
enhancement New feature or request examples Add new or update existing examples for the functions

Comments

@singla-shivam
Copy link
Member

singla-shivam commented Jul 3, 2022 •
edited
Loading

Referencing Jozty/website#35, we need to remove "Example ran successful" message from the examples. To accomplish, we need to remove the check from https://github.com/Jozty/Fae/blob/master/run-utils/examples.ts file and remove the console.assert("Example ran successful") statement from existing examples.
@singla-shivam singla-shivam added enhancement New feature or request examples Add new or update existing examples for the functions labels Jul 3, 2022
@singla-shivam singla-shivam self-assigned this Jul 3, 2022
This was referenced Jul 3, 2022
Open
Merged
@singla-shivam singla-shivam linked a pull request Jul 4, 2022 that will close this issue
feat: remove Example ran successful message #69
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@singla-shivam singla-shivam

Labels
enhancement New feature or request examples Add new or update existing examples for the functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: remove Example ran successful message Jozty/Fae
1 participant
@singla-shivam