Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) - performant context propagation #45

Merged
merged 14 commits into from
Jul 22, 2019

Conversation

JoviDeCroock
Copy link
Owner

Before I leave on vacation I decided to finish this up.

This is not mergeable yet since there are some issues in use-context-selector that should be solved upstream. This being said this solution should increase bundle size by +- 600B.

Leaving hooked-form on 2.5KB which is still far behind other similar libraries, this SHOULD make this the fastest form library.

https://bundlephobia.com/[email protected]

@JoviDeCroock JoviDeCroock requested a review from Pruxis July 12, 2019 13:14
@codecov-io
Copy link

codecov-io commented Jul 12, 2019

Codecov Report

Merging #45 into master will increase coverage by 0.48%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #45      +/-   ##
========================================
+ Coverage   99.51%   100%   +0.48%     
========================================
  Files          14     14              
  Lines         207    197      -10     
  Branches       41     37       -4     
========================================
- Hits          206    197       -9     
+ Partials        1      0       -1
Impacted Files Coverage Δ
src/useFormConnect.ts 100% <100%> (ø) ⬆️
src/Field.tsx 100% <100%> (ø) ⬆️
src/helpers/context.ts 100% <100%> (ø) ⬆️
src/useError.ts 100% <100%> (ø) ⬆️
src/FieldArray.tsx 100% <100%> (+10%) ⬆️
src/useField.ts 100% <100%> (ø) ⬆️
src/Error.tsx 100% <100%> (ø) ⬆️
src/useFieldArray.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15f469d...c8c851c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants