Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --offline mode #879

Merged
merged 9 commits into from
Sep 29, 2023
Merged

feat: add --offline mode #879

merged 9 commits into from
Sep 29, 2023

Conversation

JoshuaKGoldberg
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg commented Sep 22, 2023

PR Checklist

Overview

Adds --offline flag that skips running scripts. That includes a timeout for npm whoami, as I've found that command to hang when I'm on an airplane.

Also corrects a bit of the logic around adding the user as a contributor, while I'm in the area. And fixes up unit tests around that.

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #879 (96cea60) into main (a51c624) will increase coverage by 2.71%.
The diff coverage is 94.00%.

@@            Coverage Diff             @@
##             main     #879      +/-   ##
==========================================
+ Coverage   90.83%   93.54%   +2.71%     
==========================================
  Files          89       89              
  Lines        4681     4711      +30     
  Branches      357      373      +16     
==========================================
+ Hits         4252     4407     +155     
+ Misses        428      303     -125     
  Partials        1        1              
Flag Coverage Δ
create 71.97% <22.44%> (-0.33%) ⬇️
initialize 37.05% <61.22%> (?)
migrate 70.75% <18.36%> (-0.34%) ⬇️
unit 66.26% <86.00%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/initialize/initializeWithOptions.ts 87.09% <100.00%> (+66.46%) ⬆️
src/shared/getGitHubUserAsAllContributor.ts 100.00% <100.00%> (ø)
src/shared/options/args.ts 100.00% <100.00%> (ø)
src/shared/options/optionsSchema.ts 100.00% <100.00%> (ø)
src/shared/options/readOptions.ts 92.76% <100.00%> (+0.06%) ⬆️
src/steps/addOwnerAsAllContributor.ts 100.00% <100.00%> (ø)
src/steps/addToolAllContributors.ts 100.00% <100.00%> (ø)
src/steps/finalizeDependencies.ts 100.00% <100.00%> (ø)
src/create/createWithOptions.ts 69.11% <0.00%> (ø)
src/shared/types.ts 0.00% <0.00%> (ø)
... and 1 more

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review September 29, 2023 14:34
@JoshuaKGoldberg JoshuaKGoldberg merged commit 715e79d into main Sep 29, 2023
14 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the offline-mode branch September 29, 2023 15:04
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

🎉 This is included in version v1.32.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Add an explicit opt-in --offline mode
1 participant