fix: remove cancel-in-progress from release.yml #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #876 +/- ##
=======================================
Coverage 92.82% 92.82%
=======================================
Files 89 89
Lines 4629 4629
Branches 355 355
=======================================
Hits 4297 4297
- Misses 330 331 +1
+ Partials 2 1 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
3 tasks
|
🎉 This is included in version v1.32.0 🎉 The release is available on: Cheers! 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Switches
actions/checkout@4to fetch fromref: main(the branch) instead of the commit that triggered the workflow. Doing so should mean that every release workflow runs on the latest commit as of when it starts.This should mean that if N release-worthy commits occur quickly:
I don't love that this solution results in 1...N release workflows each deleting branch protection, doing nothing, then recreating the branch protection. But given https://github.com/orgs/community/discussions/12835 I don't see a way around it. The branch protection shenanigans should be made better by #145.