Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: .all-contributorsrc should be in cspell ignorePaths #1691

Closed
3 tasks done
JoshuaKGoldberg opened this issue Nov 25, 2024 · 1 comment · Fixed by #1694
Closed
3 tasks done

🐛 Bug: .all-contributorsrc should be in cspell ignorePaths #1691

JoshuaKGoldberg opened this issue Nov 25, 2024 · 1 comment · Fixed by #1694
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

Spell checking should not be done on autogenerated files. They should all be in the cspell.json file's ignorePaths.

Actual

.all-contributorsrc is having cspell run on it.

Additional Info

Splitting this out of #1670.

💖
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Nov 25, 2024
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Nov 25, 2024
This was referenced Nov 25, 2024
Draft
Merged
JoshuaKGoldberg added a commit that referenced this issue Nov 25, 2024
@JoshuaKGoldberg
fix: ignore .all-contributorsrc in cspell.json (#1694)
3bd0f36 
## PR Checklist

- [x] Addresses an existing open issue: fixes #1691
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

💖
@github-actions GitHub Actions
Copy link

🎉 This is included in version v1.73.7 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ignore .all-contributorsrc in cspell.json JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg