Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move .eslintignore into .eslintrc.cjs ignorePatterns #1262

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

JoshuaKGoldberg
Copy link
Owner

PR Checklist

Overview

Removes the .eslintignore file and its templating. Instead adds the ignorePatterns entry in .eslintrc.cjs and its templates.

Also adds .eslintignore to the list of cleared unnecessary files.

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (81fb3eb) 94.81% compared to head (0673629) 94.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1262      +/-   ##
==========================================
- Coverage   94.81%   94.80%   -0.01%     
==========================================
  Files         104      103       -1     
  Lines        5808     5799       -9     
  Branches      492      492              
==========================================
- Hits         5507     5498       -9     
  Misses        300      300              
  Partials        1        1              
Flag Coverage Δ
create 70.04% <85.71%> (-0.05%) ⬇️
initialize 42.23% <14.28%> (-0.01%) ⬇️
migrate 69.86% <85.71%> (-0.05%) ⬇️
unit 75.58% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 287bc46 into main Jan 17, 2024
17 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the no-eslintignore branch January 17, 2024 14:29
Copy link

🎉 This is included in version v1.55.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Move .eslintignore into ESLint config
1 participant