Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug: README.md badges don't have sufficient white-on-green color contrast #1224

Open
3 tasks done
JoshuaKGoldberg opened this issue Jan 9, 2024 · 1 comment
Open
3 tasks done
Assignees
Labels
area: documentation Improvements or additions to docs status: blocked Waiting for something else to be resolved type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Jan 9, 2024

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

https://webaim.org/articles/contrast: all text in the README.md should have >= 3.5:1 color contrast between foreground and background text.

Actual

The badges I've been using -which, I should add, use pretty a common default green 😬- only have 2.68:1: https://webaim.org/resources/contrastchecker/?fcolor=FFFFFF&bcolor=21BB42.

Additional Info

The images do apply a shadow of #218334:

Screenshot of the '💪 typescript: strict' README.md badge, zoomed in, with white text, a #218334 shadow, and #31B548 background

...but that's only underneath the text. So my hunch is it really only "counts" halfway.

@JoshuaKGoldberg JoshuaKGoldberg added area: documentation Improvements or additions to docs type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Jan 9, 2024
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Jan 9, 2024
@JoshuaKGoldberg
Copy link
Owner Author

I like #289835:

Screenshot of six README badges with white text on #289835 green background, except for 'coverage: 95%' with a lime green background

...but the codecov badge will need to updated with a custom range of colors, I think. Blocked on badges/shields#994 -> badges/shields#9890.

@JoshuaKGoldberg JoshuaKGoldberg added status: blocked Waiting for something else to be resolved and removed status: accepting prs Please, send a pull request to resolve this! labels Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation Improvements or additions to docs status: blocked Waiting for something else to be resolved type: bug Something isn't working :(
Projects
None yet
Development

No branches or pull requests

1 participant