Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: clarify option selection mechanism #1122

Merged
merged 3 commits into from
Dec 30, 2023

Conversation

johnnyreilly
Copy link
Sponsor Collaborator

@johnnyreilly johnnyreilly commented Dec 29, 2023

PR Checklist

Overview

This PR adds the text You can press ↑ and ↓ on the keyboard to change the selected item, then space to select. to the creation mechanism.

🌻

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8d48fee) 94.27% compared to head (26a70b9) 94.27%.

Files Patch % Lines
src/shared/options/augmentOptionsWithExcludes.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1122   +/-   ##
=======================================
  Coverage   94.27%   94.27%           
=======================================
  Files          97       97           
  Lines        5627     5627           
  Branches      455      455           
=======================================
  Hits         5305     5305           
  Misses        321      321           
  Partials        1        1           
Flag Coverage Δ
create 70.22% <0.00%> (ø)
initialize 42.15% <0.00%> (ø)
migrate 69.60% <0.00%> (ø)
unit 72.31% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnnyreilly
Copy link
Sponsor Collaborator Author

I see the code coverage message above, but I don't think this changes code coverage?

Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! What do you think about this small text adjustment?

src/shared/options/augmentOptionsWithExcludes.ts Outdated Show resolved Hide resolved
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swell, thanks!

@JoshuaKGoldberg JoshuaKGoldberg changed the title feat: clarify option selection mechanism #1121 feat: clarify option selection mechanism Dec 30, 2023
@JoshuaKGoldberg JoshuaKGoldberg merged commit aaad5ae into main Dec 30, 2023
17 of 18 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the feat-clearer-option-selection branch December 30, 2023 13:27
Copy link

🎉 This is included in version v1.51.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📝 Documentation: Clarify how to operate the Clack prompt
2 participants