Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove type options for aliases, matching, and onlyPrimitives #793

Closed
JoshuaKGoldberg opened this issue Dec 13, 2020 · 0 comments · Fixed by #794
Closed

Remove type options for aliases, matching, and onlyPrimitives #793

JoshuaKGoldberg opened this issue Dec 13, 2020 · 0 comments · Fixed by #794
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! 🙏 type: enhancement New feature or request

Comments

@JoshuaKGoldberg
Copy link
Owner

Overview

As a precursor to #765: the shenanigans this project does around aliasing types, filtering all types, or limiting fixes to just primitives are not anything I've felt the need to use in real world code. I found them to be more of 'bandaid' style uses to cover up an assortment of bugs that have, mostly, since been fixed.

Removing these options will make it much easier to print code in general, and directly remove added work around integrating typeToString in #765.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! 🙏 type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: switched from type aliasing to typeToString JoshuaKGoldberg/TypeStat
1 participant
@JoshuaKGoldberg