Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug: Using file-level changes and suppressTypeErrors together does not work #1546

Open
3 tasks done
rubiesonthesky opened this issue Apr 7, 2024 · 0 comments
Open
3 tasks done
Labels
status: accepting prs Please, send a pull request to resolve this! 🙏 type: bug Something isn't working :( 🐛

Comments

@rubiesonthesky
Copy link
Collaborator

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

When using these options together, they should work.

/* Above file */
(function () {
	let text: string | number;
	text = 1;
})();

Actual

Additional comments added with below or above, are not added to file.

(function () {
	let text: string | number;
	text = 1;
})();

Additional Info

Enabled suppressTypeErrors on all tests inside test/cases/files -> All test outputs are missing the comments that were supposed to be added.

For example, typestat.json

{
	"cleanups": {
		"suppressTypeErrors": true
	},
	"files": {
		"above": "/* Above file */"
	},
	"fixes": {
		"incompleteTypes": true
	}
}
@rubiesonthesky rubiesonthesky added the type: bug Something isn't working :( 🐛 label Apr 7, 2024
@JoshuaKGoldberg JoshuaKGoldberg added the status: accepting prs Please, send a pull request to resolve this! 🙏 label Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs Please, send a pull request to resolve this! 🙏 type: bug Something isn't working :( 🐛
Projects
None yet
Development

No branches or pull requests

2 participants